vagetablechicken commented on pull request #3899: URL: https://github.com/apache/incubator-doris/pull/3899#issuecomment-646484537
> The patch am not very understand. You meaning is _cur_batch and _pending_batches is not emtpy when destructor? So you clear_all_batches when destructor. @vagetablechicken Yes, we should clear _cur_batch and _pending_batches before NodeChannel's destruction.(`state->instance_mem_tracker()` has already be deleted) So it can be clear at OlapTableSink's dtor. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
