[GitHub] [doris] HappenLee commented on a diff in pull request #19789: [feature](profile)Add the filtering information of the Bloom filter in profile.

[via GitHub]

HappenLee commented on code in PR #19789:
URL: https://github.com/apache/doris/pull/19789#discussion_r1201446822


##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -1604,10 +1605,13 @@ uint16_t 
SegmentIterator::_evaluate_short_circuit_predicate(uint16_t* vec_sel_ro
         auto column_id = predicate->column_id();
         auto& short_cir_column = _current_return_columns[column_id];
         selected_size = predicate->evaluate(*short_cir_column, 
vec_sel_rowid_idx, selected_size);
+        if (predicate->get_filter_id() != -1) {

Review Comment:
   not do the work in for loop to evaluate， the work should only execute once 
time just in `init` function



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org