yiguolei commented on code in PR #19789:
URL: https://github.com/apache/doris/pull/19789#discussion_r1201386087


##########
be/src/olap/column_predicate.h:
##########
@@ -262,6 +269,8 @@ class ColumnPredicate {
     // TODO: the value is only in delete condition, better be template value
     bool _opposite;
     std::shared_ptr<PredicateParams> _predicate_params;
+    mutable uint64_t _evaluated_rows = 1;

Review Comment:
   The column predicate will be used by multi scanner thread.  So it is 
immutable in the past. If you add some state(_evaluated_rows, _passwd_rows), it 
not thread safe or may core?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to