eldenmoon commented on code in PR #18654:
URL: https://github.com/apache/doris/pull/18654#discussion_r1191857813
##########
be/src/service/internal_service.cpp:
##########
@@ -1384,15 +1386,30 @@ void
PInternalServiceImpl::response_slave_tablet_pull_rowset(
}
}
-static Status read_by_rowids(
- std::pair<size_t, size_t> row_range_idx, const TupleDescriptor& desc,
- const google::protobuf::RepeatedPtrField<PMultiGetRequest_RowId>&
rowids,
- vectorized::Block* sub_block) {
- //read from row_range.first to row_range.second
- for (size_t i = row_range_idx.first; i < row_range_idx.second; ++i) {
+Status PInternalServiceImpl::_multi_get(const PMultiGetRequest& request,
+ PMultiGetResponse* response) {
+ OlapReaderStatistics stats;
+ vectorized::Block result_block;
+
+ // init desc
+ TupleDescriptor desc(request.desc());
+ std::vector<SlotDescriptor> slots;
+ slots.reserve(request.slots().size());
+ for (const auto& pslot : request.slots()) {
+ slots.push_back(SlotDescriptor(pslot));
+ desc.add_slot(&slots.back());
Review Comment:
construct a tuple need add slot
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
