eldenmoon commented on code in PR #18654:
URL: https://github.com/apache/doris/pull/18654#discussion_r1191857630
##########
be/src/olap/tablet.cpp:
##########
@@ -2481,7 +2481,7 @@ Status Tablet::fetch_value_by_rowids(RowsetSharedPtr
input_rowset, uint32_t segi
Status Tablet::lookup_row_data(const Slice& encoded_key, const RowLocation&
row_location,
RowsetSharedPtr input_rowset, const
TupleDescriptor* desc,
- OlapReaderStatistics& stats, vectorized::Block*
block,
+ OlapReaderStatistics& stats, std::string&
values,
Review Comment:
it's a key value interface, actually use `vectorized::Block* block` is not
acurrate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
