morningman commented on a change in pull request #3120: [Temp Partition]
Support loading data into temp partitions
URL: https://github.com/apache/incubator-doris/pull/3120#discussion_r394315262
##########
File path: fe/src/main/java/org/apache/doris/planner/OlapTableSink.java
##########
@@ -293,7 +293,11 @@ private TOlapTableLocationParam createLocation(OlapTable
table) throws UserExcep
TOlapTableLocationParam locationParam = new TOlapTableLocationParam();
// BE id -> path hash
Multimap<Long, Long> allBePathsMap = HashMultimap.create();
- for (Partition partition : table.getPartitions()) {
+ for (Partition partition : table.getAllPartitions()) {
+ if (!partitionIds.isEmpty() &&
!partitionIds.contains(partition.getId())) {
Review comment:
Here I use this `if (!partitionIds.isEmpty() &&
!partitionIds.contains(partition.getId()))` to filter all unrelated partitions.
I didn't see any such check logic in `init` method?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
