morningman commented on a change in pull request #3120: [Temp Partition]
Support loading data into temp partitions
URL: https://github.com/apache/incubator-doris/pull/3120#discussion_r393723200
##########
File path: fe/src/main/java/org/apache/doris/analysis/AdminRepairTableStmt.java
##########
@@ -62,8 +63,12 @@ public void analyze(Analyzer analyzer) throws UserException
{
tblRef.getName().setDb(dbName);
- if (tblRef.getPartitions() != null &&
!tblRef.getPartitions().isEmpty()) {
- partitions.addAll(tblRef.getPartitions());
+ PartitionNames partitionNames = tblRef.getPartitionNames();
Review comment:
I can just change it to:
```
if (tblRef.isTempPartitionSpecified()) {
throw new AnalysisException("Do not support (cancel)repair temporary
partitions");
}
if (tblRef.getPartitionNames() != null) {
partitions.addAll(tblRef.getPartitionNames().getPartitionNames());
}
```
Does it better?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
