WingsGo commented on a change in pull request #3054: [Bug]Fix invalid rollback
for stream load txn
URL: https://github.com/apache/incubator-doris/pull/3054#discussion_r389497385
##########
File path: be/src/runtime/stream_load/stream_load_executor.cpp
##########
@@ -178,19 +180,24 @@ Status StreamLoadExecutor::commit_txn(StreamLoadContext*
ctx) {
TLoadTxnCommitResult result;
#ifndef BE_TEST
RETURN_IF_ERROR(ThriftRpcHelper::rpc<FrontendServiceClient>(
- master_addr.hostname, master_addr.port,
- [&request, &result] (FrontendServiceConnection& client) {
- client->loadTxnCommit(result, request);
- }, config::txn_commit_rpc_timeout_ms));
+ master_addr.hostname, master_addr.port,
+ [&request, &result](FrontendServiceConnection& client) {
+ client->loadTxnCommit(result, request);
+ },
+ config::txn_commit_rpc_timeout_ms));
#else
result = k_stream_load_commit_result;
#endif
- // Return if this transaction is committed successful; otherwise, we need
try to
+ // Return if this transaction is committed successful; otherwise, we need
try
+ // to
// rollback this transaction
Status status(result.status);
- if (!status.ok() && status.code() != TStatusCode::PUBLISH_TIMEOUT) {
+ if (!status.ok()) {
LOG(WARNING) << "commit transaction failed, errmsg=" <<
status.get_error_msg()
- << ctx->brief();
+ << ctx->brief();
+ if (status.code() != TStatusCode::PUBLISH_TIMEOUT) {
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
