morningman commented on a change in pull request #3054: [Bug]Fix invalid
rollback for stream load txn
URL: https://github.com/apache/incubator-doris/pull/3054#discussion_r389430341
##########
File path: be/src/runtime/stream_load/stream_load_executor.cpp
##########
@@ -188,7 +188,7 @@ Status StreamLoadExecutor::commit_txn(StreamLoadContext*
ctx) {
// Return if this transaction is committed successful; otherwise, we need
try to
// rollback this transaction
Status status(result.status);
- if (!status.ok()) {
+ if (!status.ok() && status.code() != TStatusCode::PUBLISH_TIMEOUT) {
Review comment:
If you change this code, when FE return PUBLISH_TIMEOUT, here it will just
return Status:OK() to the upper caller?
I think we should return PUBLISH_TIMEOUT directly, but set
ctx->need_rollback = false to false
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
