imay commented on a change in pull request #3044: Write delete predicate into
RowsetMeta upon upgrade from Doris-0.10 to Doris-0.11
URL: https://github.com/apache/incubator-doris/pull/3044#discussion_r388731229
##########
File path: be/src/olap/olap_snapshot_converter.cpp
##########
@@ -150,7 +167,15 @@ OLAPStatus OlapSnapshotConverter::to_tablet_meta_pb(const
OLAPHeaderMessage& ola
}
RowsetId next_id = StorageEngine::instance()->next_rowset_id();
RowsetMetaPB* rowset_meta = tablet_meta_pb->add_inc_rs_metas();
- convert_to_rowset_meta(inc_delta, next_id, olap_header.tablet_id(),
olap_header.schema_hash(), rowset_meta);
+ PDelta temp_inc_delta = inc_delta;
+ for (auto& del_pred : delete_conditions) {
+ if (temp_inc_delta.start_version() == temp_inc_delta.end_version()
+ && temp_inc_delta.start_version() == del_pred.version()) {
+ DeletePredicatePB* delete_condition =
temp_inc_delta.mutable_delete_condition();
+ *delete_condition = del_pred;
+ }
Review comment:
align
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
