chaoyli commented on a change in pull request #3044: Write delete predicate
into RowsetMeta upon upgrade from Doris-0.10 to Doris-0.11
URL: https://github.com/apache/incubator-doris/pull/3044#discussion_r388700694
##########
File path: be/src/olap/olap_snapshot_converter.cpp
##########
@@ -89,27 +93,27 @@ OLAPStatus OlapSnapshotConverter::to_olap_header(const
TabletMetaPB& tablet_meta
return OLAP_SUCCESS;
}
-OLAPStatus OlapSnapshotConverter::to_tablet_meta_pb(const OLAPHeaderMessage&
olap_header,
+OLAPStatus OlapSnapshotConverter::to_tablet_meta_pb(OLAPHeaderMessage*
olap_header,
Review comment:
Because PDelta can not corresponds with RowsetMeta.
So before calling convert_to_rowset_meta, I add delete predicate to PDelta
to store delete predicate.
OK, I use a PDelta temp variable to get rid of OLAPHeaderMessage.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
