kangpinghuang commented on a change in pull request #2979: Incomplete support
Array type (#2871)
URL: https://github.com/apache/incubator-doris/pull/2979#discussion_r386994292
##########
File path: be/src/util/mysql_row_buffer.cpp
##########
@@ -261,21 +321,28 @@ int MysqlRowBuffer::push_string(const char* str, int
length) {
return ret;
}
- _pos = pack_vlen(_pos, length);
+ if (NOT_DYNAMIC_MODE) {
+ _pos = pack_vlen(_pos, length);
+ }
memcpy(_pos, str, length);
_pos += length;
return 0;
}
int MysqlRowBuffer::push_null() {
+ if (!NOT_DYNAMIC_MODE) {
+ // dynamic mode not write
+ return 0;
+ }
+
int ret = reserve(1);
if (0 != ret) {
LOG(ERROR) << "mysql row buffer reserver failed.";
return ret;
}
- int1store(_pos, 251);
+ int1store(_pos, 251);
Review comment:
```suggestion
int1store(_pos, 251);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
