Seaven commented on a change in pull request #2979: Incomplete support Array 
type (#2871)
URL: https://github.com/apache/incubator-doris/pull/2979#discussion_r386782639
 
 

 ##########
 File path: be/src/util/mysql_row_buffer.cpp
 ##########
 @@ -109,15 +132,24 @@ int MysqlRowBuffer::push_tinyint(int8_t data) {
         return ret;
     }
 
-    int length = snprintf(_pos + 1, MAX_TINYINT_WIDTH + 2, "%d", data);
+    int size_bytes = 0;
+    if (NOT_DYNAMIC_MODE) {
 
 Review comment:
   Good idea, will modify it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to