kangkaisen commented on a change in pull request #2966: Add more constraints
for bitmap column
URL: https://github.com/apache/incubator-doris/pull/2966#discussion_r382877661
##########
File path: fe/src/main/java/org/apache/doris/analysis/FunctionCallExpr.java
##########
@@ -303,30 +300,20 @@ private void analyzeBuiltinAggFunction(Analyzer
analyzer) throws AnalysisExcepti
"group_concat requires first parameter to be of type
STRING: " + this.toSql());
}
Review comment:
Because there has the `type.isStringType()` check, HLL and bitmap is not
string type. we needn't check HLL and bitmap again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
