morningman commented on a change in pull request #2966: Add more constraints 
for bitmap column
URL: https://github.com/apache/incubator-doris/pull/2966#discussion_r382616051
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/catalog/Type.java
 ##########
 @@ -189,6 +189,19 @@ public boolean isStringType() {
         return isScalarType(PrimitiveType.VARCHAR) || 
isScalarType(PrimitiveType.CHAR);
     }
 
+    // only metric types have the following constraint:
+    // 1. don't support as key column
+    // 2. don't support filter
+    // 3. don't support group by
+    // 4. don't support index
+    public boolean isOnlyMetricType () {
 
 Review comment:
   ```suggestion
       public boolean isOnlyMetricType() {
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to