kangpinghuang commented on a change in pull request #2847: Doris support in
memory olap table
URL: https://github.com/apache/incubator-doris/pull/2847#discussion_r377976915
##########
File path: be/src/olap/page_cache.cpp
##########
@@ -42,11 +42,18 @@ bool StoragePageCache::lookup(const CacheKey& key,
PageCacheHandle* handle) {
return true;
}
-void StoragePageCache::insert(const CacheKey& key, const Slice& data,
PageCacheHandle* handle) {
+void StoragePageCache::insert(const CacheKey& key, const Slice& data,
PageCacheHandle* handle,
+ bool in_memory) {
Review comment:
I think is_durable is a better name?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
