kangpinghuang commented on a change in pull request #2847: Doris support in
memory olap table
URL: https://github.com/apache/incubator-doris/pull/2847#discussion_r377977089
##########
File path: be/src/olap/page_cache.h
##########
@@ -74,7 +74,7 @@ class StoragePageCache {
// Given hanlde will be set to valid reference.
// This function is thread-safe, and when two clients insert two same key
// concurrently, this function can assure that only one page is cached.
- void insert(const CacheKey& key, const Slice& data, PageCacheHandle*
handle);
+ void insert(const CacheKey& key, const Slice& data, PageCacheHandle*
handle, bool in_memory = false);
Review comment:
add some comment for this variable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
