morningman commented on a change in pull request #2781: Batch Operate Rollup
table in Doris #2671
URL: https://github.com/apache/incubator-doris/pull/2781#discussion_r367953476
##########
File path: fe/src/main/java/org/apache/doris/alter/MaterializedViewHandler.java
##########
@@ -787,11 +1079,15 @@ private void getOldAlterJobInfos(Database db,
List<List<Comparable>> rollupJobIn
@Override
public void process(List<AlterClause> alterClauses, String clusterName,
Database db, OlapTable olapTable)
throws DdlException, AnalysisException {
- for (AlterClause alterClause : alterClauses) {
+ alterClauses = sortRollupIndex(alterClauses);
+
+ Iterator<AlterClause> alterClauseIterator = alterClauses.iterator();
Review comment:
It is weird to use a iterator here, maybe just alterClauses.get(0) is
enough? Or Iterables.getOnlyElement()?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
