morningman commented on a change in pull request #2781: Batch Operate Rollup
table in Doris #2671
URL: https://github.com/apache/incubator-doris/pull/2781#discussion_r376709026
##########
File path: fe/src/main/java/org/apache/doris/alter/RollupJobV2.java
##########
@@ -305,7 +305,9 @@ protected void runWaitingTxnJob() throws
AlterCancelException {
if (db == null) {
throw new AlterCancelException("Databasee " + dbId + " does not
exist");
}
-
+
+ // TODO(wangbo): 2020/2/4 in the case that the
[WaitingTxnJob|PendingJob] is checkpointed and replayMethod won't be called,
make sure the tablet meta exists in olapTable and TabletInvertedIndex before
doris run
Review comment:
I think this comment can be removed when you keep the job's state
in PENDING after calling `replayPending()`. Am I right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
