kangkaisen commented on a change in pull request #2781: Batch Operate Rollup
table in Doris #2671
URL: https://github.com/apache/incubator-doris/pull/2781#discussion_r374016371
##########
File path: fe/src/main/java/org/apache/doris/alter/MaterializedViewHandler.java
##########
@@ -858,4 +1084,56 @@ public void cancel(CancelStmt stmt) throws DdlException {
jobDone(rollupJob);
}
}
+
+ // There may be dependency relation between user batch input rollup index
+ // e.g, user input rollup index: r1 from r2,r2 from r3 ;the input order
must be r3,r2,r1
+ // the reason for sort rollup index:
+ // son rollup must be dealed after parent rollup, because they need
parent rollup's info,such as baseRollupIndex
+ public static List<AlterClause> sortRollupIndex(List<AlterClause>
alterClauseList) {
Review comment:
This is unnecessary. We could check the
`alter statement `and **require the from index must exist firstly**, and
then, we needn't do this work
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
