wangbo commented on a change in pull request #2781: Batch Operate Rollup table
in Doris #2671
URL: https://github.com/apache/incubator-doris/pull/2781#discussion_r368426770
##########
File path: fe/src/main/java/org/apache/doris/alter/MaterializedViewHandler.java
##########
@@ -85,6 +90,71 @@ public MaterializedViewHandler() {
super("materialized view");
}
+
+ // for batch submit rollup job, tableId -> jobId
+ // keep table's not final state job size. The job size determine's table's
state, = 0 means table is normal,otherwrise is rollup
+ private Map<Long, Set<Long>> tableNotFinalStateJobMap = new
ConcurrentHashMap<>();
+ // keep table's running job,used for concurrency limit
+ private Map<Long, Set<Long>> tableRunningJobMap = new
ConcurrentHashMap<>();
+ // make sure that job's dependency just init once
+ private volatile boolean hasBuildJobDependency = false;
Review comment:
No,Dependency is necessary;
Because int both parent job is cancel or parent is not final case, we all
can't find parent index in catalog.Only 'parent index can be seen in catalog'
can't decide whether current rollup job is ready to run
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
