imay commented on a change in pull request #2782: Add file cache for v2
URL: https://github.com/apache/incubator-doris/pull/2782#discussion_r373989349
##########
File path: be/src/olap/rowset/segment_v2/bitmap_index_reader.h
##########
@@ -40,9 +40,9 @@ class IndexedColumnIterator;
class BitmapIndexReader {
public:
- explicit BitmapIndexReader(RandomAccessFile* file,
+ explicit BitmapIndexReader(const std::string file_name,
Review comment:
```suggestion
explicit BitmapIndexReader(const std::string& file_name,
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
