imay commented on a change in pull request #2782: Add file cache for v2
URL: https://github.com/apache/incubator-doris/pull/2782#discussion_r373996821
##########
File path: be/src/olap/rowset/segment_v2/segment_iterator.h
##########
@@ -120,6 +121,9 @@ class SegmentIterator : public RowwiseIterator {
// used to binary search the rowid for a given key
// only used in `_get_row_ranges_by_keys`
std::unique_ptr<RowBlockV2> _seek_block;
+
+ // Handle for file to read
+ std::unique_ptr<OpenedFileHandle<RandomAccessFile>> _file_handle;
Review comment:
Why not use OpenedFileHandle<RandomAccessFile> directly?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
