imay commented on a change in pull request #2603: Add nio support for mysql protocol implementation URL: https://github.com/apache/incubator-doris/pull/2603#discussion_r361663695
########## File path: fe/src/main/java/org/apache/doris/common/Config.java ########## @@ -266,6 +266,11 @@ */ @ConfField public static int query_port = 9030; + /* + * nio enabled + */ + @ConfField public static boolean nio_enabled = false; Review comment: Doris has many network interface, this is only for mysql interface. Better to rename it to "mysql_service_nio? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org