imay commented on a change in pull request #2603: Add nio support for mysql
protocol implementation
URL: https://github.com/apache/incubator-doris/pull/2603#discussion_r361662072
##########
File path: fe/src/main/java/org/apache/doris/qe/QeService.java
##########
@@ -37,6 +37,21 @@ public QeService(int port) {
this.port = port;
}
+ public QeService(int port, boolean nioEnabled, ConnectScheduler scheduler)
{
+ // Set up help module
+ try {
+ HelpModule.getInstance().setUpModule();
+ } catch (Exception e) {
+ LOG.error("Help module failed, because:", e);
+ }
+ this.port = port;
+ if (nioEnabled) {
+ mysqlServer = new NMysqlServer(port, scheduler);
+ } else {
+ mysqlServer = new MysqlServer(port, scheduler);
+ }
+ }
+
public QeService(int port, ConnectScheduler scheduler) {
Review comment:
If this is not used anymore. Better to remove it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
