kangpinghuang commented on a change in pull request #2573: implements create
drop show index syntax for bitmap index [#2487]
URL: https://github.com/apache/incubator-doris/pull/2573#discussion_r361604852
##########
File path: fe/src/main/java/org/apache/doris/analysis/AlterTableStmt.java
##########
@@ -61,7 +66,41 @@ public void analyze(Analyzer analyzer) throws
AnalysisException, UserException {
ErrorReport.reportAnalysisException(ErrorCode.ERR_NO_ALTER_OPERATION);
}
for (AlterClause op : ops) {
- op.analyze(analyzer);
+ if (op instanceof CreateIndexClause) {
+ Table table =
Catalog.getInstance().getDb(tbl.getDb()).getTable(tbl.getTbl());
+ if (table instanceof OlapTable) {
+ op.analyze(analyzer);
+ List<Index> indexes = ((OlapTable) table).getIndexes();
+ IndexDef indexDef = ((CreateIndexClause) op).getIndexDef();
+ for (Index idx : indexes) {
+ if
(idx.getIndexName().equalsIgnoreCase(indexDef.getIndexName())) {
Review comment:
what if user add two bitmap indexes with different names on the same column?
I think we should also check the column name and index type.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
