kangpinghuang commented on a change in pull request #2573: implements create
drop show index syntax for bitmap index [#2487]
URL: https://github.com/apache/incubator-doris/pull/2573#discussion_r361603273
##########
File path: fe/src/main/java/org/apache/doris/alter/SchemaChangeHandler.java
##########
@@ -779,6 +783,14 @@ private void createJob(long dbId, OlapTable olapTable,
Map<Long, LinkedList<Colu
} // end for property keys
}
+ // for bitmapIndex
+ boolean hasIndexChange = false;
+ Set<Index> newSet = new HashSet<>(indexes);
+ Set<Index> oriSet = new HashSet<>(olapTable.getIndexes());
+ if (!newSet.equals(oriSet)) {
+ hasIndexChange = true;
+ }
Review comment:
what if the user just modify the index name on the same column by creating
the same index type?
In this case, it seems that we just modify the column's index name and
return ok.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
