kangpinghuang commented on a change in pull request #2549: fix segment size URL: https://github.com/apache/incubator-doris/pull/2549#discussion_r361174559
########## File path: be/src/olap/rowset/segment_v2/segment_writer.cpp ########## @@ -109,8 +109,10 @@ template Status SegmentWriter::append_row(const ContiguousRow& row); uint64_t SegmentWriter::estimate_segment_size() { uint64_t size = 8; //magic size + int index = 0; for (auto& column_writer : _column_writers) { size += column_writer->estimate_buffer_size(); + index++; Review comment: remove it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org