imay commented on a change in pull request #2549: fix segment size
URL: https://github.com/apache/incubator-doris/pull/2549#discussion_r361090815
##########
File path: be/src/olap/rowset/segment_v2/column_writer.h
##########
@@ -108,8 +108,7 @@ class ColumnWriter {
struct Page {
int32_t first_rowid;
int32_t num_rows;
- OwnedSlice null_bitmap;
- OwnedSlice data;
+ std::vector<OwnedSlice> data;
Review comment:
It will be better to introduce an OwnedSlice named compressed_data. If you
reuse the data struct, it will make this struct difficult to understand.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
