imay commented on a change in pull request #2441: Add zip util(#2348) URL: https://github.com/apache/incubator-doris/pull/2441#discussion_r358832738
########## File path: be/src/util/zip_util.cpp ########## @@ -0,0 +1,166 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + + +#include "util/zip_util.h" +#include "util/file_utils.h" +#include "gutil/strings/substitute.h" +#include "gutil/strings/util.h" +#include "env/env.h" +#include "util/time.h" + +namespace doris { + +#define DEFAULT_FILE_NAME_SIZE 256 + +#define BREAK_IF_STATUS_ERROR(stmt) { \ + st = (stmt); \ + if (UNLIKELY(!st.ok())) { \ + break; \ + } \ +} + +using namespace strings; + +Status ZipFile::open() { + _zip_file = unzOpen64(_zip_path.c_str()); + if (_zip_file == nullptr) { + return Status::InvalidArgument("open zip file: " + _zip_path + " error"); + } + + return Status::OK(); +} + +Status ZipFile::close() { + if (!_close) { + unzClose(_zip_file); + _close = true; + } + + return Status::OK(); +} + +Status ZipFile::extract(const std::string& target_path, const std::string& dir_name) { + // check zip file + if (_zip_file == nullptr) { + return Status::IOError("zip file is not open"); + } + + unz_global_info64 global_info; + int err = unzGetGlobalInfo64(_zip_file, &global_info); + + if (err != UNZ_OK) { + return Status::IOError(strings::Substitute("read zip file info $0 error, code: $1", _zip_path, err)); + } + + // 0.check target path + std::string target = target_path + "/" + dir_name; + if (FileUtils::check_exist(target)) { + return Status::AlreadyExist("path already exists: " + target); + } + + // 1.create temp directory + std::string temp = target_path + "/.tmp_" + std::to_string(GetCurrentTimeMicros()) + "_" + dir_name; + RETURN_IF_ERROR(FileUtils::create_dir(temp)); + + // 2.unzip to temp directory + Status st; + for (int i = 0; i < global_info.number_entry; ++i) { + st = extract_file(_zip_file, temp); + if (!st.ok()) { + FileUtils::remove_all(temp); + return st; + } + unzGoToNextFile(_zip_file); + } + + // 3.move to target directory + st = Env::Default()->rename_file(temp, target); + if (!st.ok()) { + FileUtils::remove_all(temp); + return st; + } + return Status::OK(); + +} + +Status ZipFile::extract_file(unzFile zfile, const std::string& target_path) { + int err; + char file_name[DEFAULT_FILE_NAME_SIZE]; + + unz_file_info64 file_info_inzip; + + err = unzGetCurrentFileInfo64(zfile, &file_info_inzip, file_name, DEFAULT_FILE_NAME_SIZE, + nullptr, 0, nullptr, 0); + + if (err != UNZ_OK) { + return Status::IOError(strings::Substitute("read zip file info error, code: $0", err)); + } + + // is directory, mkdir + std::string path = target_path + "/" + std::string(file_name); + + if (HasSuffixString(file_name, "/") || HasSuffixString(file_name, "\\")) { + FileUtils::create_dir(path); + + return Status::OK(); + } + + // is file, unzip + Status st = Status::OK(); + char* file_data = nullptr; + do { + err = unzOpenCurrentFile(zfile); + if (UNZ_OK != err) { + st = Status::IOError(strings::Substitute("read zip file $0 info error, code: $1", file_name, err)); + break; + } + + uint64_t file_size = file_info_inzip.uncompressed_size; + file_data = (char *)malloc(file_size); Review comment: better to use std::unique_ptr<char[]> ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
