imay commented on a change in pull request #2441: Add zip util(#2348) URL: https://github.com/apache/incubator-doris/pull/2441#discussion_r356986819
########## File path: be/src/util/zip_util.h ########## @@ -0,0 +1,39 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#ifndef DORIS_BE_SRC_UTIL_ZIP_UTIL_H +#define DORIS_BE_SRC_UTIL_ZIP_UTIL_H + +#include <string> + +#include "common/status.h" + +namespace doris { + +/** + * extract .zip file to $(target path)/$(target directory) + * + * @param zip_path .zip file path + * @param target_path target path + * @param target_directory target directory name and prefix without '/' or '\\', like 'test' not '/test' + */ +Status zip_extract(const std::string& zip_path, const std::string& target_path, const std::string& target_directory); Review comment: It's better to encapsulate this function in a class, then it will be easy to clean all intermediate file/dir ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
