imay commented on a change in pull request #2471: add block split bloom filter
URL: https://github.com/apache/incubator-doris/pull/2471#discussion_r358817259
##########
File path: be/src/olap/rowset/segment_v2/column_reader.cpp
##########
@@ -224,6 +225,39 @@ Status ColumnReader::_calculate_row_ranges(const
std::vector<uint32_t>& page_ind
return Status::OK();
}
+Status ColumnReader::get_row_ranges_by_bloom_filter(CondColumn* cond_column,
+ OlapReaderStatistics* stats, RowRanges* row_ranges) {
+ RowRanges bf_row_ranges;
+ std::unique_ptr<BloomFilterIndexIterator> bf_iter;
+ RETURN_IF_ERROR(_bloom_filter_index_reader->new_iterator(&bf_iter));
+ size_t range_size = row_ranges->range_size();
+ // get covered page ids
+ std::set<uint32_t> page_ids;
+ for (int i = 0; i < range_size; ++i) {
+ int64_t from = row_ranges->get_range_from(i);
+ int64_t idx = from;
+ int64_t to = row_ranges->get_range_to(i);
+ auto iter =
_ordinal_index->seek_at_or_before(row_ranges->get_range_from(i));
Review comment:
```suggestion
auto iter = _ordinal_index->seek_at_or_before(from);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
