imay commented on a change in pull request #2471: add block split bloom filter
URL: https://github.com/apache/incubator-doris/pull/2471#discussion_r358178999
##########
File path: be/src/olap/rowset/beta_rowset_writer.cpp
##########
@@ -161,6 +161,7 @@ RowsetSharedPtr BetaRowsetWriter::build() {
OLAPStatus BetaRowsetWriter::_create_segment_writer() {
auto path = BetaRowset::segment_file_path(_context.rowset_path_prefix,
_context.rowset_id, _num_segment);
segment_v2::SegmentWriterOptions writer_options;
+ writer_options.has_bf_for_unique_agg_column = _context.version.first == 0;
Review comment:
I think this is not only valid for bf, for example flter is also applied.
And I think it is not appropriate to have "unique", "agg" here. Because in the
segment level, it should not be aware of aggregate or unique.
So you'd better to choose another name for it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
