njnu-seafish commented on code in PR #17939:
URL:
https://github.com/apache/dolphinscheduler/pull/17939#discussion_r2766681911
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/executor/plugin/condition/ConditionLogicTask.java:
##########
@@ -95,9 +95,11 @@ private DependResult calculateConditionResult() {
private DependResult getDependResultForItem(ConditionDependentItem item,
Map<Long, TaskInstance> taskInstanceMap) {
TaskInstance taskInstance = taskInstanceMap.get(item.getDepTaskCode());
if (taskInstance == null) {
- log.info("The depend item: {} has not completed yet",
DependResult.FAILED);
- log.info("The dependent result will be {}", DependResult.FAILED);
- return DependResult.FAILED;
+ // Dependent task not found – likely misconfigured task code
+ log.error("Dependent task definition missing, depTaskCode: {}",
item.getDepTaskCode());
+ throw new RuntimeException(String.format(
+ "Dependency validation failed: task code %d not found in
current workflow. Check dependency config: %s",
+ item.getDepTaskCode(), item));
Review Comment:
> The condition task might contains multiple predecessors, you cannot simple
throw exception if one task instance is null here.
But in this case, the original evaluation logic would seem quite odd: It
would be impossible to determine whether the condition task should succeed or
fail.
For a condition task, if any of its dependent predecessor tasks hasn't been
executed, should it preferably throw an exception? After all, the evaluation
condition would be incomplete—unless we explicitly account for more complex
logical relationships like AND, OR, or NOT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
