njnu-seafish commented on code in PR #17939:
URL:
https://github.com/apache/dolphinscheduler/pull/17939#discussion_r2758462105
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/executor/plugin/condition/ConditionLogicTask.java:
##########
@@ -95,9 +95,11 @@ private DependResult calculateConditionResult() {
private DependResult getDependResultForItem(ConditionDependentItem item,
Map<Long, TaskInstance> taskInstanceMap) {
TaskInstance taskInstance = taskInstanceMap.get(item.getDepTaskCode());
if (taskInstance == null) {
- log.info("The depend item: {} has not completed yet",
DependResult.FAILED);
- log.info("The dependent result will be {}", DependResult.FAILED);
- return DependResult.FAILED;
+ // Dependent task not found – likely misconfigured task code
+ log.error("Dependent task definition missing, depTaskCode: {}",
item.getDepTaskCode());
+ throw new RuntimeException(String.format(
+ "Dependency validation failed: task code %d not found in
current workflow. Check dependency config: %s",
+ item.getDepTaskCode(), item));
Review Comment:
> instances here, such as when execution starts from a specific node.
If task pre-sh is skipped and execution proceeds directly to the condition
task, should the condition task succeed or fail? I still think throwing an
exception is more reasonable in this case.
<img width="1825" height="751" alt="企业微信截图_17701213764286"
src="https://github.com/user-attachments/assets/0d0ac00a-1b9c-4cd6-a429-5e4f7e1bc1df";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
