siyi-09 opened a new issue, #17450:
URL: https://github.com/apache/dolphinscheduler/issues/17450

   ### Search before asking
   
   - [x] I had searched in the 
[issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and 
found no similar issues.
   
   
   ### What happened
   
   SEATUNEL option parameters not support local parameter replacement
   Existing code:
   SeatunnelEngineTask.java 53
   @OverRide
   public List buildOptions() throws Exception {
   List args = super.buildOptions();
   if (!Objects.isNull(seatunnelParameters.getDeployMode())) {
   args.add(Constants.DEPLOY_MODE_OPTIONS);
   args.add(seatunnelParameters.getDeployMode().getCommand());
   }
   if (StringUtils.isNotBlank(seatunnelParameters.getOthers())) {
   args.add(seatunnelParameters.getOthers());
   }
   return args;
   }
   
   ### What you expected to happen
   
   @Override
       public List<String> buildOptions() throws Exception {
           List<String> args = super.buildOptions();
           if (!Objects.isNull(seatunnelParameters.getDeployMode())) {
               args.add(Constants.DEPLOY_MODE_OPTIONS);
               args.add(seatunnelParameters.getDeployMode().getCommand());
           }
           if (StringUtils.isNotBlank(seatunnelParameters.getOthers())) {
               args.add(parseOthers());
           }
           return args;
       }
   
       private String parseOthers() {
           // combining local and global parameters
           Map<String, Property> paramsMap = 
taskExecutionContext.getPrepareParamsMap();
           return 
ParameterUtils.convertParameterPlaceholders(seatunnelParameters.getOthers(), 
ParameterUtils.convert(paramsMap));
       }
   
   ### How to reproduce
   
   Add option parameter - n "${workflowID}" to the seatunnel node
   Add custom parameters
   workflowID in varchar ${system.workflow.instance.id}
   After running, it can be found that the parameter after the - n option has 
not been replaced.
   
   ### Anything else
   
   _No response_
   
   ### Version
   
   dev
   
   ### Are you willing to submit PR?
   
   - [x] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [x] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: 
[email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to