siyi-09 opened a new issue, #17449:
URL: https://github.com/apache/dolphinscheduler/issues/17449

   ### Search before asking
   
   - [x] I had searched in the 
[issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and 
found no similar feature requirement.
   
   
   ### Description
   
   SEATUNEL option parameters not support local parameter replacement
   
   Existing code:
   SeatunnelEngineTask.java 53
       @Override
       public List<String> buildOptions() throws Exception {
           List<String> args = super.buildOptions();
           if (!Objects.isNull(seatunnelParameters.getDeployMode())) {
               args.add(Constants.DEPLOY_MODE_OPTIONS);
               args.add(seatunnelParameters.getDeployMode().getCommand());
           }
           if (StringUtils.isNotBlank(seatunnelParameters.getOthers())) {
               args.add(seatunnelParameters.getOthers());
           }
           return args;
       }
   
   **Suggest modifying the code:**
       @Override
       public List<String> buildOptions() throws Exception {
           List<String> args = super.buildOptions();
           if (!Objects.isNull(seatunnelParameters.getDeployMode())) {
               args.add(Constants.DEPLOY_MODE_OPTIONS);
               args.add(seatunnelParameters.getDeployMode().getCommand());
           }
           if (StringUtils.isNotBlank(seatunnelParameters.getOthers())) {
               args.add(parseOthers());
           }
           return args;
       }
   
       private String parseOthers() {
           // combining local and global parameters
           Map<String, Property> paramsMap = 
taskExecutionContext.getPrepareParamsMap();
           return 
ParameterUtils.convertParameterPlaceholders(seatunnelParameters.getOthers(), 
ParameterUtils.convert(paramsMap));
       }
   
   ### Are you willing to submit a PR?
   
   - [x] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [x] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: 
[email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to