SbloodyS commented on code in PR #16420:
URL:
https://github.com/apache/dolphinscheduler/pull/16420#discussion_r1710530475
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-procedure/src/main/java/org/apache/dolphinscheduler/plugin/task/procedure/ProcedureParameters.java:
##########
@@ -104,6 +104,14 @@ public void dealOutParam4Procedure(Object result, String
pop) {
return;
}
properties.get(pop).setValue(String.valueOf(result));
+ if (!varPool.isEmpty()) {
+ for (Property info : varPool) {
+ if (pop.equals(info.getProp())) {
+ varPool.remove(info);
+ break;
+ }
+ }
+ }
Review Comment:
After I take a deep look at it, I think we should make the following changes.
1. Deduplication should be performed at the place where varpool was
initialized.
2. Add duplicate check at the front-end.
3. Add duplicate check at the backend-end api.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
