wangxj3 commented on code in PR #16420:
URL: 
https://github.com/apache/dolphinscheduler/pull/16420#discussion_r1706270066


##########
dolphinscheduler-task-plugin/dolphinscheduler-task-procedure/src/main/java/org/apache/dolphinscheduler/plugin/task/procedure/ProcedureParameters.java:
##########
@@ -104,6 +104,14 @@ public void dealOutParam4Procedure(Object result, String 
pop) {
             return;
         }
         properties.get(pop).setValue(String.valueOf(result));
+        if (!varPool.isEmpty()) {
+            for (Property info : varPool) {
+                if (pop.equals(info.getProp())) {
+                    varPool.remove(info);
+                    break;
+                }
+            }
+        }

Review Comment:
   other task type use the mothod of AbstractParameters.dealOutParam .only 
procedure task handle output parameters in this way.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to