ruanwenjun commented on code in PR #15912:
URL:
https://github.com/apache/dolphinscheduler/pull/15912#discussion_r1579284117
##########
dolphinscheduler-ui/src/views/projects/workflow/definition/components/start-modal.tsx:
##########
@@ -505,16 +504,13 @@ export default defineComponent({
label={t('project.workflow.parallelism')}
path='expectedParallelismNumber'
>
- <NCheckbox v-model:checked={this.parallelismRef}>
- {t('project.workflow.custom_parallelism')}
- </NCheckbox>
- <NInput
- allowInput={this.trim}
- disabled={!this.parallelismRef}
+ <NInputNumber
placeholder={t(
'project.workflow.please_enter_parallelism'
)}
v-model:value={this.startForm.expectedParallelismNumber}
+ max='100'
+ min='1'
Review Comment:
Master/Worker has its own protection strategy, I don't think we should rely
on a workflow config to protect the system. And I don't think we can get the
correct upper limit at this discussion, different user have different cluster
size and usage Scenarios, if we don't know how to set the max value, why we
need to set. In additional, if we want to avoid the system crash in a large
parallel, the correct way is to limit the rate at server side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
