ruanwenjun commented on code in PR #15912:
URL:
https://github.com/apache/dolphinscheduler/pull/15912#discussion_r1579248490
##########
dolphinscheduler-ui/src/views/projects/workflow/definition/components/start-modal.tsx:
##########
@@ -505,16 +504,13 @@ export default defineComponent({
label={t('project.workflow.parallelism')}
path='expectedParallelismNumber'
>
- <NCheckbox v-model:checked={this.parallelismRef}>
- {t('project.workflow.custom_parallelism')}
- </NCheckbox>
- <NInput
- allowInput={this.trim}
- disabled={!this.parallelismRef}
+ <NInputNumber
placeholder={t(
'project.workflow.please_enter_parallelism'
)}
v-model:value={this.startForm.expectedParallelismNumber}
+ max='100'
+ min='1'
Review Comment:
It's not a good idea to restrict the parallelism should between `1` and
`100`, this shouldn't be restricted.
##########
dolphinscheduler-ui/src/views/projects/workflow/definition/components/use-form.ts:
##########
@@ -66,7 +66,7 @@ export const useForm = () => {
tenantCode: 'default',
environmentCode: null,
startParams: null,
- expectedParallelismNumber: '',
+ expectedParallelismNumber: '2',
Review Comment:
Why the default value is 2 rather than 3? If you want to set a default
value, I would prefer 1 or a default empty value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
