Add final modifier to method parameters. Project: http://git-wip-us.apache.org/repos/asf/commons-text/repo Commit: http://git-wip-us.apache.org/repos/asf/commons-text/commit/f6214db8 Tree: http://git-wip-us.apache.org/repos/asf/commons-text/tree/f6214db8 Diff: http://git-wip-us.apache.org/repos/asf/commons-text/diff/f6214db8
Branch: refs/heads/master Commit: f6214db8c8452471051ad3540f2cc4b69d5f7ba6 Parents: 25299c5 Author: Gary Gregory <ggreg...@apache.org> Authored: Sat Nov 19 10:32:23 2016 -0800 Committer: Gary Gregory <ggreg...@apache.org> Committed: Sat Nov 19 10:32:23 2016 -0800 ---------------------------------------------------------------------- .../apache/commons/text/AlphabetConverter.java | 26 ++++++++++---------- .../commons/text/diff/StringsComparator.java | 4 +-- .../commons/text/names/HumanNameParser.java | 2 +- .../org/apache/commons/text/names/Name.java | 4 +-- .../commons/text/names/NameParseException.java | 10 ++++---- .../apache/commons/text/names/NameString.java | 6 ++--- .../commons/text/similarity/CosineDistance.java | 2 +- .../text/similarity/CosineSimilarity.java | 10 ++++---- .../apache/commons/text/similarity/Counter.java | 2 +- .../text/similarity/EditDistanceFrom.java | 2 +- .../commons/text/similarity/FuzzyScore.java | 2 +- .../text/similarity/HammingDistance.java | 2 +- .../text/similarity/JaroWinklerDistance.java | 2 +- .../similarity/LevenshteinDetailedDistance.java | 8 +++--- .../text/similarity/LevenshteinDistance.java | 4 +-- .../text/similarity/LevenshteinResults.java | 2 +- .../commons/text/similarity/RegexTokenizer.java | 2 +- .../text/similarity/SimilarityScoreFrom.java | 2 +- .../commons/text/AlphabetConverterTest.java | 2 +- .../text/diff/ReplacementsFinderTest.java | 6 ++--- .../commons/text/names/HumanNameParserTest.java | 2 +- .../text/similarity/CosineDistanceTest.java | 2 +- .../ParameterizedEditDistanceFromTest.java | 2 +- .../ParameterizedSimilarityScoreFromTest.java | 2 +- .../text/translate/EntityArraysTest.java | 2 +- 25 files changed, 55 insertions(+), 55 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/commons-text/blob/f6214db8/src/main/java/org/apache/commons/text/AlphabetConverter.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/text/AlphabetConverter.java b/src/main/java/org/apache/commons/text/AlphabetConverter.java index b3ab00b..d77a204 100644 --- a/src/main/java/org/apache/commons/text/AlphabetConverter.java +++ b/src/main/java/org/apache/commons/text/AlphabetConverter.java @@ -94,8 +94,8 @@ public final class AlphabetConverter { * @param encodedToOriginal encoding alphabet * @param encodedLetterLength length of the encoded letter */ - private AlphabetConverter(Map<Integer, String> originalToEncoded, Map<String, String> encodedToOriginal, - int encodedLetterLength) { + private AlphabetConverter(final Map<Integer, String> originalToEncoded, final Map<String, String> encodedToOriginal, + final int encodedLetterLength) { this.originalToEncoded = originalToEncoded; this.encodedToOriginal = encodedToOriginal; @@ -109,7 +109,7 @@ public final class AlphabetConverter { * @return the encoded string, {@code null} if the given string is null * @throws UnsupportedEncodingException if chars that are not supported are encountered */ - public String encode(String original) throws UnsupportedEncodingException { + public String encode(final String original) throws UnsupportedEncodingException { if (original == null) { return null; } @@ -141,7 +141,7 @@ public final class AlphabetConverter { * @return the decoded string, {@code null} if the given string is null * @throws UnsupportedEncodingException if unexpected characters that cannot be handled are encountered */ - public String decode(String encoded) throws UnsupportedEncodingException { + public String decode(final String encoded) throws UnsupportedEncodingException { if (encoded == null) { return null; } @@ -205,8 +205,8 @@ public final class AlphabetConverter { * @param doNotEncodeMap map of values that should not be encoded */ @SuppressWarnings("PMD") - private void addSingleEncoding(int level, String currentEncoding, Collection<Integer> encoding, - Iterator<Integer> originals, Map<Integer, String> doNotEncodeMap) { + private void addSingleEncoding(final int level, final String currentEncoding, final Collection<Integer> encoding, + final Iterator<Integer> originals, final Map<Integer, String> doNotEncodeMap) { if (level > 0) { for (int encodingLetter : encoding) { @@ -257,7 +257,7 @@ public final class AlphabetConverter { } @Override - public boolean equals(Object obj) { + public boolean equals(final Object obj) { if (obj == null) { return false; } @@ -286,7 +286,7 @@ public final class AlphabetConverter { * @return the reconstructed AlphabetConverter * @see AlphabetConverter#getOriginalToEncoded() */ - public static AlphabetConverter createConverterFromMap(Map<Integer, String> originalToEncoded) { + public static AlphabetConverter createConverterFromMap(final Map<Integer, String> originalToEncoded) { final Map<Integer, String> unmodifiableOriginalToEncoded = Collections.unmodifiableMap(originalToEncoded); Map<String, String> encodedToOriginal = new LinkedHashMap<>(); Map<Integer, String> doNotEncodeMap = new HashMap<>(); @@ -322,8 +322,8 @@ public final class AlphabetConverter { * @return the AlphabetConverter * @throws IllegalArgumentException if an AlphabetConverter cannot be constructed */ - public static AlphabetConverter createConverterFromChars(Character[] original, Character[] encoding, - Character[] doNotEncode) { + public static AlphabetConverter createConverterFromChars(final Character[] original, final Character[] encoding, + final Character[] doNotEncode) { return AlphabetConverter.createConverter(convertCharsToIntegers(original), convertCharsToIntegers(encoding), convertCharsToIntegers(doNotEncode)); } @@ -334,7 +334,7 @@ public final class AlphabetConverter { * @param chars array of characters * @return an equivalent array of integers */ - private static Integer[] convertCharsToIntegers(Character[] chars) { + private static Integer[] convertCharsToIntegers(final Character[] chars) { if (chars == null || chars.length == 0) { return new Integer[0]; } @@ -358,7 +358,7 @@ public final class AlphabetConverter { * @return the AlphabetConverter * @throws IllegalArgumentException if an AlphabetConverter cannot be constructed */ - public static AlphabetConverter createConverter(Integer[] original, Integer[] encoding, Integer[] doNotEncode) { + public static AlphabetConverter createConverter(final Integer[] original, final Integer[] encoding, final Integer[] doNotEncode) { Set<Integer> originalCopy = new LinkedHashSet<>(Arrays.<Integer> asList(original)); Set<Integer> encodingCopy = new LinkedHashSet<>(Arrays.<Integer> asList(encoding)); @@ -449,7 +449,7 @@ public final class AlphabetConverter { * @return a new string with the new code point * @see http://www.oracle.com/us/technologies/java/supplementary-142654.html */ - private static String codePointToString(int i) { + private static String codePointToString(final int i) { if (Character.charCount(i) == 1) { return String.valueOf((char) i); } else { http://git-wip-us.apache.org/repos/asf/commons-text/blob/f6214db8/src/main/java/org/apache/commons/text/diff/StringsComparator.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/text/diff/StringsComparator.java b/src/main/java/org/apache/commons/text/diff/StringsComparator.java index 2c8fb15..7825df9 100644 --- a/src/main/java/org/apache/commons/text/diff/StringsComparator.java +++ b/src/main/java/org/apache/commons/text/diff/StringsComparator.java @@ -84,7 +84,7 @@ public class StringsComparator { * @param left first character sequence to be compared * @param right second character sequence to be compared */ - public StringsComparator(String left, String right) { + public StringsComparator(final String left, final String right) { this.left = left; this.right = right; @@ -179,7 +179,7 @@ public class StringsComparator { * @param end2 the end of the second sequence to be compared * @return the middle snake */ - private Snake getMiddleSnake(int start1, int end1, int start2, int end2) { + private Snake getMiddleSnake(final int start1, final int end1, final int start2, final int end2) { // Myers Algorithm // Initialisations final int m = end1 - start1; http://git-wip-us.apache.org/repos/asf/commons-text/blob/f6214db8/src/main/java/org/apache/commons/text/names/HumanNameParser.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/text/names/HumanNameParser.java b/src/main/java/org/apache/commons/text/names/HumanNameParser.java index f97f162..d9822a2 100644 --- a/src/main/java/org/apache/commons/text/names/HumanNameParser.java +++ b/src/main/java/org/apache/commons/text/names/HumanNameParser.java @@ -132,7 +132,7 @@ public final class HumanNameParser { * @throws NullPointerException if name is null. * @return The name object */ - public Name parse(String name) { + public Name parse(final String name) { Objects.requireNonNull(name, "Parameter 'name' must not be null."); NameString nameString = new NameString(name); http://git-wip-us.apache.org/repos/asf/commons-text/blob/f6214db8/src/main/java/org/apache/commons/text/names/Name.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/text/names/Name.java b/src/main/java/org/apache/commons/text/names/Name.java index fefefd5..80141a5 100644 --- a/src/main/java/org/apache/commons/text/names/Name.java +++ b/src/main/java/org/apache/commons/text/names/Name.java @@ -60,7 +60,7 @@ public final class Name { * @param lastName the last name * @param suffix a suffix */ - Name(String leadingInitial, String firstName, String nickName, String middleName, String lastName, String suffix) { + Name(final String leadingInitial, final String firstName, final String nickName, final String middleName, final String lastName, final String suffix) { this.leadingInitial = leadingInitial; this.firstName = firstName; this.nickName = nickName; @@ -124,7 +124,7 @@ public final class Name { } @Override - public boolean equals(Object o) { + public boolean equals(final Object o) { if (this == o) { return true; } http://git-wip-us.apache.org/repos/asf/commons-text/blob/f6214db8/src/main/java/org/apache/commons/text/names/NameParseException.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/text/names/NameParseException.java b/src/main/java/org/apache/commons/text/names/NameParseException.java index 4fe5eda..90f9fd7 100644 --- a/src/main/java/org/apache/commons/text/names/NameParseException.java +++ b/src/main/java/org/apache/commons/text/names/NameParseException.java @@ -38,7 +38,7 @@ public final class NameParseException extends RuntimeException { * * @param message message */ - public NameParseException(String message) { + public NameParseException(final String message) { super(message); } @@ -47,7 +47,7 @@ public final class NameParseException extends RuntimeException { * * @param cause cause */ - public NameParseException(Throwable cause) { + public NameParseException(final Throwable cause) { super(cause); } @@ -57,7 +57,7 @@ public final class NameParseException extends RuntimeException { * @param message message * @param cause cause */ - public NameParseException(String message, Throwable cause) { + public NameParseException(final String message, final Throwable cause) { super(message, cause); } @@ -69,8 +69,8 @@ public final class NameParseException extends RuntimeException { * @param enableSuppression flag to enable suppression * @param writableStackTrace a writable stack trace */ - public NameParseException(String message, Throwable cause, - boolean enableSuppression, boolean writableStackTrace) { + public NameParseException(final String message, final Throwable cause, + final boolean enableSuppression, final boolean writableStackTrace) { super(message, cause, enableSuppression, writableStackTrace); } http://git-wip-us.apache.org/repos/asf/commons-text/blob/f6214db8/src/main/java/org/apache/commons/text/names/NameString.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/text/names/NameString.java b/src/main/java/org/apache/commons/text/names/NameString.java index 21898d3..9513176 100644 --- a/src/main/java/org/apache/commons/text/names/NameString.java +++ b/src/main/java/org/apache/commons/text/names/NameString.java @@ -37,7 +37,7 @@ final class NameString { * * @param str encapsulated string. */ - NameString(String str) { + NameString(final String str) { this.str = str; } @@ -60,7 +60,7 @@ final class NameString { * @param submatchIndex which of the parenthesized submatches to use * @return the part of the namestring that got chopped off */ - String chopWithRegex(String regex, int submatchIndex) { + String chopWithRegex(final String regex, final int submatchIndex) { String chopped = ""; Pattern pattern = Pattern.compile(regex); Matcher matcher = pattern.matcher(this.str); @@ -96,7 +96,7 @@ final class NameString { * @param flipAroundChar the character(s) demarcating the two halves you want to flip. * @throws NameParseException if a regex fails or a condition is not expected */ - void flip(String flipAroundChar) { + void flip(final String flipAroundChar) { String[] parts = this.str.split(flipAroundChar); if (parts.length == 2) { this.str = String.format("%s %s", parts[1], parts[0]); http://git-wip-us.apache.org/repos/asf/commons-text/blob/f6214db8/src/main/java/org/apache/commons/text/similarity/CosineDistance.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/text/similarity/CosineDistance.java b/src/main/java/org/apache/commons/text/similarity/CosineDistance.java index c5e8853..f9a34ab 100644 --- a/src/main/java/org/apache/commons/text/similarity/CosineDistance.java +++ b/src/main/java/org/apache/commons/text/similarity/CosineDistance.java @@ -35,7 +35,7 @@ public class CosineDistance implements EditDistance<Double> { private final CosineSimilarity cosineSimilarity = new CosineSimilarity(); @Override - public Double apply(CharSequence left, CharSequence right) { + public Double apply(final CharSequence left, final CharSequence right) { CharSequence[] leftTokens = tokenizer.tokenize(left); CharSequence[] rightTokens = tokenizer.tokenize(right); http://git-wip-us.apache.org/repos/asf/commons-text/blob/f6214db8/src/main/java/org/apache/commons/text/similarity/CosineSimilarity.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/text/similarity/CosineSimilarity.java b/src/main/java/org/apache/commons/text/similarity/CosineSimilarity.java index b33a0de..5e9af0d 100644 --- a/src/main/java/org/apache/commons/text/similarity/CosineSimilarity.java +++ b/src/main/java/org/apache/commons/text/similarity/CosineSimilarity.java @@ -38,7 +38,7 @@ public class CosineSimilarity { * @param rightVector right vector * @return cosine similarity between the two vectors */ - public Double cosineSimilarity(Map<CharSequence, Integer> leftVector, Map<CharSequence, Integer> rightVector) { + public Double cosineSimilarity(final Map<CharSequence, Integer> leftVector, final Map<CharSequence, Integer> rightVector) { if (leftVector == null || rightVector == null) { throw new IllegalArgumentException("Vectors must not be null"); } @@ -70,8 +70,8 @@ public class CosineSimilarity { * @param rightVector right vector map * @return common strings */ - private Set<CharSequence> getIntersection(Map<CharSequence, Integer> leftVector, - Map<CharSequence, Integer> rightVector) { + private Set<CharSequence> getIntersection(final Map<CharSequence, Integer> leftVector, + final Map<CharSequence, Integer> rightVector) { Set<CharSequence> intersection = new HashSet<>(leftVector.keySet()); intersection.retainAll(rightVector.keySet()); return intersection; @@ -87,8 +87,8 @@ public class CosineSimilarity { * @param intersection common elements * @return the dot product */ - private double dot(Map<CharSequence, Integer> leftVector, Map<CharSequence, Integer> rightVector, - Set<CharSequence> intersection) { + private double dot(final Map<CharSequence, Integer> leftVector, final Map<CharSequence, Integer> rightVector, + final Set<CharSequence> intersection) { long dotProduct = 0; for (CharSequence key : intersection) { dotProduct += leftVector.get(key) * rightVector.get(key); http://git-wip-us.apache.org/repos/asf/commons-text/blob/f6214db8/src/main/java/org/apache/commons/text/similarity/Counter.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/text/similarity/Counter.java b/src/main/java/org/apache/commons/text/similarity/Counter.java index 1302aef..e095ba9 100644 --- a/src/main/java/org/apache/commons/text/similarity/Counter.java +++ b/src/main/java/org/apache/commons/text/similarity/Counter.java @@ -44,7 +44,7 @@ final class Counter { * @param tokens array of tokens * @return dict, where the elements are key, and the count the value */ - public static Map<CharSequence, Integer> of(CharSequence[] tokens) { + public static Map<CharSequence, Integer> of(final CharSequence[] tokens) { final Map<CharSequence, Integer> innerCounter = new HashMap<>(); for (CharSequence token : tokens) { if (innerCounter.containsKey(token)) { http://git-wip-us.apache.org/repos/asf/commons-text/blob/f6214db8/src/main/java/org/apache/commons/text/similarity/EditDistanceFrom.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/text/similarity/EditDistanceFrom.java b/src/main/java/org/apache/commons/text/similarity/EditDistanceFrom.java index 5f2f4cc..3462895 100644 --- a/src/main/java/org/apache/commons/text/similarity/EditDistanceFrom.java +++ b/src/main/java/org/apache/commons/text/similarity/EditDistanceFrom.java @@ -86,7 +86,7 @@ public class EditDistanceFrom<R> { * @param right the second CharSequence * @return the similarity score between two CharSequences */ - public R apply(CharSequence right) { + public R apply(final CharSequence right) { return editDistance.apply(left, right); } http://git-wip-us.apache.org/repos/asf/commons-text/blob/f6214db8/src/main/java/org/apache/commons/text/similarity/FuzzyScore.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/text/similarity/FuzzyScore.java b/src/main/java/org/apache/commons/text/similarity/FuzzyScore.java index 0863aa0..3393028 100644 --- a/src/main/java/org/apache/commons/text/similarity/FuzzyScore.java +++ b/src/main/java/org/apache/commons/text/similarity/FuzzyScore.java @@ -78,7 +78,7 @@ public class FuzzyScore { * @throws IllegalArgumentException if either String input {@code null} or * Locale input {@code null} */ - public Integer fuzzyScore(CharSequence term, CharSequence query) { + public Integer fuzzyScore(final CharSequence term, final CharSequence query) { if (term == null || query == null) { throw new IllegalArgumentException("Strings must not be null"); } http://git-wip-us.apache.org/repos/asf/commons-text/blob/f6214db8/src/main/java/org/apache/commons/text/similarity/HammingDistance.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/text/similarity/HammingDistance.java b/src/main/java/org/apache/commons/text/similarity/HammingDistance.java index 7fdbc17..87ad8d7 100644 --- a/src/main/java/org/apache/commons/text/similarity/HammingDistance.java +++ b/src/main/java/org/apache/commons/text/similarity/HammingDistance.java @@ -53,7 +53,7 @@ public class HammingDistance implements EditDistance<Integer> { * if they do not have the same length */ @Override - public Integer apply(CharSequence left, CharSequence right) { + public Integer apply(final CharSequence left, final CharSequence right) { if (left == null || right == null) { throw new IllegalArgumentException("Strings must not be null"); } http://git-wip-us.apache.org/repos/asf/commons-text/blob/f6214db8/src/main/java/org/apache/commons/text/similarity/JaroWinklerDistance.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/text/similarity/JaroWinklerDistance.java b/src/main/java/org/apache/commons/text/similarity/JaroWinklerDistance.java index 04f7ddf..b2a65d1 100644 --- a/src/main/java/org/apache/commons/text/similarity/JaroWinklerDistance.java +++ b/src/main/java/org/apache/commons/text/similarity/JaroWinklerDistance.java @@ -73,7 +73,7 @@ public class JaroWinklerDistance implements SimilarityScore<Double> { * @throws IllegalArgumentException if either String input {@code null} */ @Override - public Double apply(CharSequence left, CharSequence right) { + public Double apply(final CharSequence left, final CharSequence right) { final double defaultScalingFactor = 0.1; final double percentageRoundValue = 100.0; http://git-wip-us.apache.org/repos/asf/commons-text/blob/f6214db8/src/main/java/org/apache/commons/text/similarity/LevenshteinDetailedDistance.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/text/similarity/LevenshteinDetailedDistance.java b/src/main/java/org/apache/commons/text/similarity/LevenshteinDetailedDistance.java index 89c3681..e8994dc 100644 --- a/src/main/java/org/apache/commons/text/similarity/LevenshteinDetailedDistance.java +++ b/src/main/java/org/apache/commons/text/similarity/LevenshteinDetailedDistance.java @@ -96,7 +96,7 @@ public class LevenshteinDetailedDistance implements EditDistance<LevenshteinResu * @return result distance, or -1 * @throws IllegalArgumentException if either String input {@code null} */ - public LevenshteinResults apply(CharSequence left, CharSequence right) { + public LevenshteinResults apply(final CharSequence left, final CharSequence right) { if (threshold != null) { return limitedCompare(left, right, threshold); } else { @@ -153,7 +153,7 @@ public class LevenshteinDetailedDistance implements EditDistance<LevenshteinResu * @param threshold the target threshold, must not be negative * @return result distance, or -1 */ - private static LevenshteinResults limitedCompare(CharSequence left, CharSequence right, int threshold) { //NOPMD + private static LevenshteinResults limitedCompare(CharSequence left, CharSequence right, final int threshold) { //NOPMD if (left == null || right == null) { throw new IllegalArgumentException("Strings must not be null"); } @@ -429,8 +429,8 @@ public class LevenshteinDetailedDistance implements EditDistance<LevenshteinResu * character sequence were swapped to save memory * @return result object containing the count of insert, delete and substitute and total count needed */ - private static LevenshteinResults findDetailedResults(CharSequence left, CharSequence right, int[][] matrix, - boolean swapped) { + private static LevenshteinResults findDetailedResults(final CharSequence left, final CharSequence right, final int[][] matrix, + final boolean swapped) { int delCount = 0; int addCount = 0; http://git-wip-us.apache.org/repos/asf/commons-text/blob/f6214db8/src/main/java/org/apache/commons/text/similarity/LevenshteinDistance.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/text/similarity/LevenshteinDistance.java b/src/main/java/org/apache/commons/text/similarity/LevenshteinDistance.java index 5a9ae3f..b41abcb 100644 --- a/src/main/java/org/apache/commons/text/similarity/LevenshteinDistance.java +++ b/src/main/java/org/apache/commons/text/similarity/LevenshteinDistance.java @@ -104,7 +104,7 @@ public class LevenshteinDistance implements EditDistance<Integer> { * @return result distance, or -1 * @throws IllegalArgumentException if either String input {@code null} */ - public Integer apply(CharSequence left, CharSequence right) { + public Integer apply(final CharSequence left, final CharSequence right) { if (threshold != null) { return limitedCompare(left, right, threshold); } else { @@ -161,7 +161,7 @@ public class LevenshteinDistance implements EditDistance<Integer> { * @param threshold the target threshold, must not be negative * @return result distance, or -1 */ - private static int limitedCompare(CharSequence left, CharSequence right, int threshold) { // NOPMD + private static int limitedCompare(CharSequence left, CharSequence right, final int threshold) { // NOPMD if (left == null || right == null) { throw new IllegalArgumentException("Strings must not be null"); } http://git-wip-us.apache.org/repos/asf/commons-text/blob/f6214db8/src/main/java/org/apache/commons/text/similarity/LevenshteinResults.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/text/similarity/LevenshteinResults.java b/src/main/java/org/apache/commons/text/similarity/LevenshteinResults.java index 9da8235..cdb06ee 100644 --- a/src/main/java/org/apache/commons/text/similarity/LevenshteinResults.java +++ b/src/main/java/org/apache/commons/text/similarity/LevenshteinResults.java @@ -99,7 +99,7 @@ public class LevenshteinResults { } @Override - public boolean equals(Object o) { + public boolean equals(final Object o) { if (this == o) { return true; } http://git-wip-us.apache.org/repos/asf/commons-text/blob/f6214db8/src/main/java/org/apache/commons/text/similarity/RegexTokenizer.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/text/similarity/RegexTokenizer.java b/src/main/java/org/apache/commons/text/similarity/RegexTokenizer.java index 2853111..c3a742d 100644 --- a/src/main/java/org/apache/commons/text/similarity/RegexTokenizer.java +++ b/src/main/java/org/apache/commons/text/similarity/RegexTokenizer.java @@ -34,7 +34,7 @@ class RegexTokenizer implements Tokenizer<CharSequence> { * @throws IllegalArgumentException if the input text is blank */ @Override - public CharSequence[] tokenize(CharSequence text) { + public CharSequence[] tokenize(final CharSequence text) { if (text == null || text.toString().trim().equals("")) { throw new IllegalArgumentException("Invalid text"); } http://git-wip-us.apache.org/repos/asf/commons-text/blob/f6214db8/src/main/java/org/apache/commons/text/similarity/SimilarityScoreFrom.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/commons/text/similarity/SimilarityScoreFrom.java b/src/main/java/org/apache/commons/text/similarity/SimilarityScoreFrom.java index 475e0ed..e4fe794 100644 --- a/src/main/java/org/apache/commons/text/similarity/SimilarityScoreFrom.java +++ b/src/main/java/org/apache/commons/text/similarity/SimilarityScoreFrom.java @@ -86,7 +86,7 @@ public class SimilarityScoreFrom<R> { * @param right the second CharSequence * @return the similarity score between two CharSequences */ - public R apply(CharSequence right) { + public R apply(final CharSequence right) { return similarityScore.apply(left, right); } http://git-wip-us.apache.org/repos/asf/commons-text/blob/f6214db8/src/test/java/org/apache/commons/text/AlphabetConverterTest.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/text/AlphabetConverterTest.java b/src/test/java/org/apache/commons/text/AlphabetConverterTest.java index 21c137c..f73f898 100644 --- a/src/test/java/org/apache/commons/text/AlphabetConverterTest.java +++ b/src/test/java/org/apache/commons/text/AlphabetConverterTest.java @@ -168,7 +168,7 @@ public class AlphabetConverterTest { AlphabetConverter.createConverterFromChars(lower_case_english, english_and_numbers, numbers); } - private void test(Character[] originalChars, Character[] encodingChars, Character[] doNotEncodeChars, String... strings) throws UnsupportedEncodingException { + private void test(final Character[] originalChars, final Character[] encodingChars, final Character[] doNotEncodeChars, final String... strings) throws UnsupportedEncodingException { AlphabetConverter ac = AlphabetConverter.createConverterFromChars(originalChars, encodingChars, doNotEncodeChars); http://git-wip-us.apache.org/repos/asf/commons-text/blob/f6214db8/src/test/java/org/apache/commons/text/diff/ReplacementsFinderTest.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/text/diff/ReplacementsFinderTest.java b/src/test/java/org/apache/commons/text/diff/ReplacementsFinderTest.java index c6a3c93..1341fd5 100644 --- a/src/test/java/org/apache/commons/text/diff/ReplacementsFinderTest.java +++ b/src/test/java/org/apache/commons/text/diff/ReplacementsFinderTest.java @@ -59,8 +59,8 @@ public class ReplacementsFinderTest { } }); } - public ReplacementsFinderTest(String left, String right, int skipped, - Character[] from, Character[] to) { + public ReplacementsFinderTest(final String left, final String right, final int skipped, + final Character[] from, final Character[] to) { this.left = left; this.right = right; this.skipped = skipped; @@ -98,7 +98,7 @@ public class ReplacementsFinderTest { return to; } @Override - public void handleReplacement(int skipped, List<Character> from, List<Character> to) { + public void handleReplacement(final int skipped, final List<Character> from, final List<Character> to) { this.skipped += skipped; this.from.addAll(from); this.to.addAll(to); http://git-wip-us.apache.org/repos/asf/commons-text/blob/f6214db8/src/test/java/org/apache/commons/text/names/HumanNameParserTest.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/text/names/HumanNameParserTest.java b/src/test/java/org/apache/commons/text/names/HumanNameParserTest.java index f6c9ba6..3e84206 100644 --- a/src/test/java/org/apache/commons/text/names/HumanNameParserTest.java +++ b/src/test/java/org/apache/commons/text/names/HumanNameParserTest.java @@ -70,7 +70,7 @@ public class HumanNameParserTest { * * @param record a CSVRecord representing one record in the input file. */ - private void validateRecord(CSVRecord record) { + private void validateRecord(final CSVRecord record) { Name result = nameParser.parse(record.get(Columns.Name)); long recordNum = record.getRecordNumber(); http://git-wip-us.apache.org/repos/asf/commons-text/blob/f6214db8/src/test/java/org/apache/commons/text/similarity/CosineDistanceTest.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/text/similarity/CosineDistanceTest.java b/src/test/java/org/apache/commons/text/similarity/CosineDistanceTest.java index 27fb4ab..6734416 100644 --- a/src/test/java/org/apache/commons/text/similarity/CosineDistanceTest.java +++ b/src/test/java/org/apache/commons/text/similarity/CosineDistanceTest.java @@ -63,7 +63,7 @@ public class CosineDistanceTest { * @param value a value * @return rounded up value */ - private Double roundValue(Double value) { + private Double roundValue(final Double value) { return (Double) new BigDecimal(value).setScale(2, RoundingMode.HALF_UP).doubleValue(); } http://git-wip-us.apache.org/repos/asf/commons-text/blob/f6214db8/src/test/java/org/apache/commons/text/similarity/ParameterizedEditDistanceFromTest.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/text/similarity/ParameterizedEditDistanceFromTest.java b/src/test/java/org/apache/commons/text/similarity/ParameterizedEditDistanceFromTest.java index 891be27..0775a0a 100644 --- a/src/test/java/org/apache/commons/text/similarity/ParameterizedEditDistanceFromTest.java +++ b/src/test/java/org/apache/commons/text/similarity/ParameterizedEditDistanceFromTest.java @@ -68,7 +68,7 @@ public class ParameterizedEditDistanceFromTest<R> { { new EditDistance<Boolean>() { - public Boolean apply(CharSequence left, CharSequence right) { + public Boolean apply(final CharSequence left, final CharSequence right) { return left == right || (left != null && left.equals(right)); } }, http://git-wip-us.apache.org/repos/asf/commons-text/blob/f6214db8/src/test/java/org/apache/commons/text/similarity/ParameterizedSimilarityScoreFromTest.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/text/similarity/ParameterizedSimilarityScoreFromTest.java b/src/test/java/org/apache/commons/text/similarity/ParameterizedSimilarityScoreFromTest.java index a5fc915..ba39a04 100644 --- a/src/test/java/org/apache/commons/text/similarity/ParameterizedSimilarityScoreFromTest.java +++ b/src/test/java/org/apache/commons/text/similarity/ParameterizedSimilarityScoreFromTest.java @@ -44,7 +44,7 @@ public class ParameterizedSimilarityScoreFromTest<R> { { new SimilarityScore<Boolean>() { - public Boolean apply(CharSequence left, CharSequence right) { + public Boolean apply(final CharSequence left, final CharSequence right) { return left == right || (left != null && left.equals(right)); } }, http://git-wip-us.apache.org/repos/asf/commons-text/blob/f6214db8/src/test/java/org/apache/commons/text/translate/EntityArraysTest.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/text/translate/EntityArraysTest.java b/src/test/java/org/apache/commons/text/translate/EntityArraysTest.java index f1451b5..f797f83 100644 --- a/src/test/java/org/apache/commons/text/translate/EntityArraysTest.java +++ b/src/test/java/org/apache/commons/text/translate/EntityArraysTest.java @@ -94,7 +94,7 @@ public class EntityArraysTest { testEscapeVsUnescapeArrays(EntityArrays.JAVA_CTRL_CHARS_ESCAPE(), EntityArrays.JAVA_CTRL_CHARS_ESCAPE()); } - private void testEscapeVsUnescapeArrays(String[][] escapeArray, String[][] unescapeArray) { + private void testEscapeVsUnescapeArrays(final String[][] escapeArray, final String[][] unescapeArray) { for (String[] escapeElement : escapeArray) { for (String[] unescapeElement : unescapeArray) { if (escapeElement[0] == unescapeElement[1]) {
