Repository: commons-text Updated Branches: refs/heads/master 5888d4945 -> c62c658f7
Add final modifier to private fields. Project: http://git-wip-us.apache.org/repos/asf/commons-text/repo Commit: http://git-wip-us.apache.org/repos/asf/commons-text/commit/25299c59 Tree: http://git-wip-us.apache.org/repos/asf/commons-text/tree/25299c59 Diff: http://git-wip-us.apache.org/repos/asf/commons-text/diff/25299c59 Branch: refs/heads/master Commit: 25299c59903f263054204958806abef771194332 Parents: 5888d49 Author: Gary Gregory <ggreg...@apache.org> Authored: Sat Nov 19 10:32:01 2016 -0800 Committer: Gary Gregory <ggreg...@apache.org> Committed: Sat Nov 19 10:32:01 2016 -0800 ---------------------------------------------------------------------- .../commons/text/diff/ReplacementsFinderTest.java | 14 +++++++------- .../commons/text/diff/StringsComparatorTest.java | 2 +- 2 files changed, 8 insertions(+), 8 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/commons-text/blob/25299c59/src/test/java/org/apache/commons/text/diff/ReplacementsFinderTest.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/text/diff/ReplacementsFinderTest.java b/src/test/java/org/apache/commons/text/diff/ReplacementsFinderTest.java index d611475..c6a3c93 100644 --- a/src/test/java/org/apache/commons/text/diff/ReplacementsFinderTest.java +++ b/src/test/java/org/apache/commons/text/diff/ReplacementsFinderTest.java @@ -32,11 +32,11 @@ import org.junit.runners.Parameterized.Parameters; @RunWith(Parameterized.class) public class ReplacementsFinderTest { private SimpleHandler handler = null; - private String left; - private String right; - private int skipped; - private Character[] from; - private Character[] to; + private final String left; + private final String right; + private final int skipped; + private final Character[] from; + private final Character[] to; @Before public void setUp() { handler = new SimpleHandler(); @@ -81,8 +81,8 @@ public class ReplacementsFinderTest { // Helper RecplacementsHandler implementation for testing private class SimpleHandler implements ReplacementsHandler<Character> { private int skipped; - private List<Character> from; - private List<Character> to; + private final List<Character> from; + private final List<Character> to; public SimpleHandler() { skipped = 0; from = new ArrayList<>(); http://git-wip-us.apache.org/repos/asf/commons-text/blob/25299c59/src/test/java/org/apache/commons/text/diff/StringsComparatorTest.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/text/diff/StringsComparatorTest.java b/src/test/java/org/apache/commons/text/diff/StringsComparatorTest.java index fe8ef49..9c03ff1 100644 --- a/src/test/java/org/apache/commons/text/diff/StringsComparatorTest.java +++ b/src/test/java/org/apache/commons/text/diff/StringsComparatorTest.java @@ -52,7 +52,7 @@ public class StringsComparatorTest { } } private class ExecutionVisitor<T> implements CommandVisitor<T> { - private StringBuilder v; + private final StringBuilder v; public ExecutionVisitor() { v = new StringBuilder(); }
