Author: sebb
Date: Thu May 19 15:31:10 2016
New Revision: 1744597
URL: http://svn.apache.org/viewvc?rev=1744597&view=rev
Log:
CODEC-221 HmacUtils.updateHmac calls reset() unnecessarily
Modified:
commons/proper/codec/trunk/src/changes/changes.xml
commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/HmacUtils.java
Modified: commons/proper/codec/trunk/src/changes/changes.xml
URL:
http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/changes/changes.xml?rev=1744597&r1=1744596&r2=1744597&view=diff
==============================================================================
--- commons/proper/codec/trunk/src/changes/changes.xml (original)
+++ commons/proper/codec/trunk/src/changes/changes.xml Thu May 19 15:31:10 2016
@@ -42,8 +42,10 @@ The <action> type attribute can be add,u
<author>Apache Commons Developers</author>
</properties>
<body>
- <release version="1.11" date="DD MM 2015" description="Feature and fix
release.">
- <action dev="sebb" type="fix" issue="CODEC-200" due-to="Luciano
Vernaschi">Base32.HEX_DECODE_TABLE contains the wrong value 32</action>
+ <release version="1.11" date="DD MM 2015" description="Feature and fix
release.">
+ <!-- The first attribute below should be the issue id; makes it easier
to navigate in the IDE outline -->
+ <action issue="CODEC-221" dev="sebb" type="update">HmacUtils.updateHmac
calls reset() unnecessarily</action>
+ <action issue="CODEC-200" dev="sebb" type="fix" due-to="Luciano
Vernaschi">Base32.HEX_DECODE_TABLE contains the wrong value 32</action>
<action dev="ggregory" type="fix" issue="CODEC-207" due-to="Gary
Gregory">Charsets Javadoc breaks build when using Java 8</action>
<action dev="ggregory" type="fix" issue="CODEC-199" due-to="Yossi
Tamari">Bug in HW rule in Soundex</action>
<action dev="ggregory" type="fix" issue="CODEC-209" due-to="Gary
Gregory">Javadoc for SHA-224 DigestUtils methods should mention Java 1.8.0
restriction instead of 1.4.0.</action>
Modified:
commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/HmacUtils.java
URL:
http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/HmacUtils.java?rev=1744597&r1=1744596&r2=1744597&view=diff
==============================================================================
---
commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/HmacUtils.java
(original)
+++
commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/HmacUtils.java
Thu May 19 15:31:10 2016
@@ -792,7 +792,7 @@ public final class HmacUtils {
// update
/**
- * Updates the given {@link Mac} with the value.
+ * Resets and then updates the given {@link Mac} with the value.
*
* @param mac
* the initialized {@link Mac} to update
@@ -809,7 +809,7 @@ public final class HmacUtils {
}
/**
- * Updates the given {@link Mac} with the value.
+ * Resets and then updates the given {@link Mac} with the value.
*
* @param mac
* the initialized {@link Mac} to update
@@ -838,7 +838,7 @@ public final class HmacUtils {
}
/**
- * Updates the given {@link Mac} with the value.
+ * Resets and then updates the given {@link Mac} with the value.
*
* @param mac
* the initialized {@link Mac} to update
