Author: sebb Date: Thu May 19 15:25:21 2016 New Revision: 1744596 URL: http://svn.apache.org/viewvc?rev=1744596&view=rev Log: CODEC-215 Constructors must not call overrideable methods
Modified: commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/PureJavaCrc32.java Modified: commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/PureJavaCrc32.java URL: http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/PureJavaCrc32.java?rev=1744596&r1=1744595&r2=1744596&view=diff ============================================================================== --- commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/PureJavaCrc32.java (original) +++ commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/PureJavaCrc32.java Thu May 19 15:25:21 2016 @@ -43,7 +43,7 @@ public class PureJavaCrc32 implements Ch /** Create a new PureJavaCrc32 object. */ public PureJavaCrc32() { - reset(); + _reset(); } @Override @@ -53,6 +53,11 @@ public class PureJavaCrc32 implements Ch @Override public void reset() { + _reset(); + } + + // called by ctor, so must not be overrideable + private void _reset() { crc = 0xffffffff; }