Author: britter
Date: Fri Jul 26 21:27:21 2013
New Revision: 1507460
URL: http://svn.apache.org/r1507460
Log:
Split up failure tests and use annotation based style
Modified:
commons/proper/email/trunk/src/test/java/org/apache/commons/mail/EmailTest.java
Modified:
commons/proper/email/trunk/src/test/java/org/apache/commons/mail/EmailTest.java
URL:
http://svn.apache.org/viewvc/commons/proper/email/trunk/src/test/java/org/apache/commons/mail/EmailTest.java?rev=1507460&r1=1507459&r2=1507460&view=diff
==============================================================================
---
commons/proper/email/trunk/src/test/java/org/apache/commons/mail/EmailTest.java
(original)
+++
commons/proper/email/trunk/src/test/java/org/apache/commons/mail/EmailTest.java
Fri Jul 26 21:27:21 2013
@@ -245,25 +245,24 @@ public class EmailTest extends AbstractE
assertEquals(
Integer.MAX_VALUE,
Integer.valueOf(this.email.getSmtpPort()).intValue());
+ }
- // ====================================================================
- // Test Exceptions
- // ====================================================================
- int[] testExs = {Integer.MIN_VALUE, -1, 0};
+ @Test(expected = IllegalArgumentException.class)
+ public void testSetSmtpPortZero()
+ {
+ this.email.setSmtpPort(0);
+ }
- for (int i = 0; i < testExs.length; i++)
- {
- try
- {
- this.email.setSmtpPort(testExs[i]);
- fail("Should have thrown an exception");
- }
- catch (IllegalArgumentException e)
- {
- assertTrue(true);
- }
- }
+ @Test(expected = IllegalArgumentException.class)
+ public void testSetSmptPortNegative()
+ {
+ this.email.setSmtpPort(-1);
+ }
+ @Test(expected = IllegalArgumentException.class)
+ public void testSetSmtpPortMinValue()
+ {
+ this.email.setSmtpPort(Integer.MIN_VALUE);
}
@Test
