Author: britter Date: Fri Jul 26 21:21:40 2013 New Revision: 1507451 URL: http://svn.apache.org/r1507451 Log: Simplify test by using actual values instead of iterating over an array of length two
Modified: commons/proper/email/trunk/src/test/java/org/apache/commons/mail/EmailTest.java Modified: commons/proper/email/trunk/src/test/java/org/apache/commons/mail/EmailTest.java URL: http://svn.apache.org/viewvc/commons/proper/email/trunk/src/test/java/org/apache/commons/mail/EmailTest.java?rev=1507451&r1=1507450&r2=1507451&view=diff ============================================================================== --- commons/proper/email/trunk/src/test/java/org/apache/commons/mail/EmailTest.java (original) +++ commons/proper/email/trunk/src/test/java/org/apache/commons/mail/EmailTest.java Fri Jul 26 21:21:40 2013 @@ -236,18 +236,15 @@ public class EmailTest extends AbstractE @Test public void testGetSetSmtpPort() { - // ==================================================================== - // Test Success - // ==================================================================== - int[] tests = {1, Integer.MAX_VALUE}; + this.email.setSmtpPort(1); + assertEquals( + 1, + Integer.valueOf(this.email.getSmtpPort()).intValue()); - for (int i = 0; i < tests.length; i++) - { - this.email.setSmtpPort(tests[i]); - assertEquals( - tests[i], - Integer.valueOf(this.email.getSmtpPort()).intValue()); - } + this.email.setSmtpPort(Integer.MAX_VALUE); + assertEquals( + Integer.MAX_VALUE, + Integer.valueOf(this.email.getSmtpPort()).intValue()); // ==================================================================== // Test Exceptions