(commons-validator) branch master updated: Use @@MethodSource and add more CUSIP fixtures

[ggregory]

This is an automated email from the ASF dual-hosted git repository.

garydgregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-validator.git


The following commit(s) were added to refs/heads/master by this push:
     new 5a3b88af Use @@MethodSource and add more CUSIP fixtures
5a3b88af is described below

commit 5a3b88af05a5f78b4f644d8dc6917830014a5257
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Thu Jun 4 11:18:40 2026 -0400

    Use @@MethodSource and add more CUSIP fixtures
---
 .../validator/routines/checkdigit/CUSIPCheckDigitTest.java  | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git 
a/src/test/java/org/apache/commons/validator/routines/checkdigit/CUSIPCheckDigitTest.java
 
b/src/test/java/org/apache/commons/validator/routines/checkdigit/CUSIPCheckDigitTest.java
index 8b37d38d..54b4b3f3 100644
--- 
a/src/test/java/org/apache/commons/validator/routines/checkdigit/CUSIPCheckDigitTest.java
+++ 
b/src/test/java/org/apache/commons/validator/routines/checkdigit/CUSIPCheckDigitTest.java
@@ -23,16 +23,21 @@ import static org.junit.jupiter.api.Assertions.assertTrue;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.params.ParameterizedTest;
 import org.junit.jupiter.params.provider.MethodSource;
-import org.junit.jupiter.params.provider.ValueSource;
 
 /**
  * CUSIP Check Digit Test.
  */
 class CUSIPCheckDigitTest extends AbstractCheckDigitTest {
 
-    private static final String[] VALID = new String[] { "DUS0421C5", 
"037833100", "931142103", "837649128", "392690QT3", "594918104", "86770G101", 
"Y8295N109",
+    private static final String[] INVALID = { "DUS0421CW", "DUS0421CN", 
"DUS0421CE", "0378#3100" };
+
+    private static final String[] VALID = { "DUS0421C5", "037833100", 
"931142103", "837649128", "392690QT3", "594918104", "86770G101", "Y8295N109",
             "G8572F100", "17275R102", "EJ7125481" };
 
+    static String[] cloneInvalid() {
+        return INVALID.clone();
+    }
+
     static String[] cloneValid() {
         return VALID.clone();
     }
@@ -44,11 +49,11 @@ class CUSIPCheckDigitTest extends AbstractCheckDigitTest {
     protected void setUp() {
         routine = CUSIPCheckDigit.CUSIP_CHECK_DIGIT;
         valid = cloneValid();
-        invalid = new String[] { "0378#3100" };
+        invalid = cloneInvalid();
     }
 
     @ParameterizedTest
-    @ValueSource(strings = { "DUS0421CW", "DUS0421CN", "DUS0421CE" })
+    
@MethodSource("org.apache.commons.validator.routines.checkdigit.CUSIPCheckDigitTest#cloneInvalid")
     void testValidator336InvalidCheckDigits(final String invalidCheckDigit) {
         assertFalse(routine.isValid(invalidCheckDigit), "Should fail: " + 
invalidCheckDigit);
     }