(commons-validator) branch master updated: Use @@MethodSource and add more CUSIP fixtures

[ggregory]

This is an automated email from the ASF dual-hosted git repository.

garydgregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-validator.git


The following commit(s) were added to refs/heads/master by this push:
     new 9b359eba Use @@MethodSource and add more CUSIP fixtures
9b359eba is described below

commit 9b359eba1ade4e4ba6adc2b98a99ee029e8995d6
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Thu Jun 4 11:15:17 2026 -0400

    Use @@MethodSource and add more CUSIP fixtures
---
 .../validator/routines/checkdigit/CUSIPCheckDigitTest.java   | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git 
a/src/test/java/org/apache/commons/validator/routines/checkdigit/CUSIPCheckDigitTest.java
 
b/src/test/java/org/apache/commons/validator/routines/checkdigit/CUSIPCheckDigitTest.java
index 737a2cb5..8b37d38d 100644
--- 
a/src/test/java/org/apache/commons/validator/routines/checkdigit/CUSIPCheckDigitTest.java
+++ 
b/src/test/java/org/apache/commons/validator/routines/checkdigit/CUSIPCheckDigitTest.java
@@ -22,6 +22,7 @@ import static org.junit.jupiter.api.Assertions.assertTrue;
 
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.MethodSource;
 import org.junit.jupiter.params.provider.ValueSource;
 
 /**
@@ -29,13 +30,20 @@ import org.junit.jupiter.params.provider.ValueSource;
  */
 class CUSIPCheckDigitTest extends AbstractCheckDigitTest {
 
+    private static final String[] VALID = new String[] { "DUS0421C5", 
"037833100", "931142103", "837649128", "392690QT3", "594918104", "86770G101", 
"Y8295N109",
+            "G8572F100", "17275R102", "EJ7125481" };
+
+    static String[] cloneValid() {
+        return VALID.clone();
+    }
+
     /**
      * Sets up routine & valid codes.
      */
     @BeforeEach
     protected void setUp() {
         routine = CUSIPCheckDigit.CUSIP_CHECK_DIGIT;
-        valid = new String[] { "037833100", "931142103", "837649128", 
"392690QT3", "594918104", "86770G101", "Y8295N109", "G8572F100" };
+        valid = cloneValid();
         invalid = new String[] { "0378#3100" };
     }
 
@@ -46,7 +54,7 @@ class CUSIPCheckDigitTest extends AbstractCheckDigitTest {
     }
 
     @ParameterizedTest
-    @ValueSource(strings = { "DUS0421C5", "037833100", "17275R102", 
"38259P508", "594918104", "EJ7125481" })
+    
@MethodSource("org.apache.commons.validator.routines.checkdigit.CUSIPCheckDigitTest#cloneValid")
     void testValidator336ValidCheckDigits(final String validCheckDigit) {
         assertTrue(routine.isValid(validCheckDigit), "Should fail: " + 
validCheckDigit);
     }