(commons-text) 08/14: Fix PMD UnnecessaryFullyQualifiedName in StringSubstitutor

[ggregory]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-text.git

commit 78a29c9eca551e838fca9cc642c1812bf1b65910
Author: Gary D. Gregory <garydgreg...@gmail.com>
AuthorDate: Sat Jul 19 13:42:57 2025 -0400

    Fix PMD UnnecessaryFullyQualifiedName in StringSubstitutor
---
 src/changes/changes.xml                                      | 1 +
 src/main/java/org/apache/commons/text/StringSubstitutor.java | 5 ++---
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index 4af56c0b..87e599fb 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -51,6 +51,7 @@ The <action> type attribute can be add,update,fix,remove.
     <action type="fix" dev="ggregory" due-to="Gary Gregory">Fix PMD 
UnnecessaryFullyQualifiedName in DefaultStringLookupsHolder.</action>
     <action type="fix" dev="ggregory" due-to="Gary Gregory">Fix PMD 
UnnecessaryFullyQualifiedName in PropertiesStringLookup.</action>
     <action type="fix" dev="ggregory" due-to="Gary Gregory">Fix PMD 
UnnecessaryFullyQualifiedName in JavaPlatformStringLookup.</action>
+    <action type="fix" dev="ggregory" due-to="Gary Gregory">Fix PMD 
UnnecessaryFullyQualifiedName in StringSubstitutor.</action>
     <!-- ADD -->
     <action type="add" dev="ggregory" due-to="Gary Gregory">Interface 
StringLookup now extends UnaryOperator&lt;String&gt;.</action>
     <action type="add" dev="ggregory" due-to="Gary Gregory">Interface 
TextRandomProvider extends IntUnaryOperator.</action>
diff --git a/src/main/java/org/apache/commons/text/StringSubstitutor.java 
b/src/main/java/org/apache/commons/text/StringSubstitutor.java
index 60141915..1780d972 100644
--- a/src/main/java/org/apache/commons/text/StringSubstitutor.java
+++ b/src/main/java/org/apache/commons/text/StringSubstitutor.java
@@ -434,8 +434,7 @@ public class StringSubstitutor {
         if (valueProperties == null) {
             return source.toString();
         }
-        return StringSubstitutor.replace(source,
-                
valueProperties.stringPropertyNames().stream().collect(Collectors.toMap(Function.identity(),
 valueProperties::getProperty)));
+        return replace(source, 
valueProperties.stringPropertyNames().stream().collect(Collectors.toMap(Function.identity(),
 valueProperties::getProperty)));
     }
 
     /**
@@ -637,7 +636,7 @@ public class StringSubstitutor {
     }
 
     /**
-     * Creates a new instance based on the given StringSubstitutor.
+     * Creates a new instance based on the given 
      *
      * @param other The StringSubstitutor used as the source.
      * @since 1.9